-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(DLI): import DLI global variable resource and add unit test and document. #1034
Merged
ShiChangkuo
merged 1 commit into
FlexibleEngineCloud:master
from
Zippo-Wang:migrate_DLI-dli_global_variable
Oct 24, 2023
Merged
feat(DLI): import DLI global variable resource and add unit test and document. #1034
ShiChangkuo
merged 1 commit into
FlexibleEngineCloud:master
from
Zippo-Wang:migrate_DLI-dli_global_variable
Oct 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zippo-Wang
force-pushed
the
migrate_DLI-dli_global_variable
branch
from
October 11, 2023 06:25
830b904
to
16879ad
Compare
Zippo-Wang
changed the title
test(DLI): import DLI global variable resource and add unit test and document.
feat(DLI): import DLI global variable resource and add unit test and document.
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some little nits, can you fix them.
flexibleengine/acceptance/resource_flexibleengine_dli_global_variable_test.go
Outdated
Show resolved
Hide resolved
flexibleengine/acceptance/resource_flexibleengine_dli_global_variable_test.go
Outdated
Show resolved
Hide resolved
Zippo-Wang
force-pushed
the
migrate_DLI-dli_global_variable
branch
from
October 16, 2023 09:20
16879ad
to
68c01ec
Compare
/lgtm |
|
||
# flexibleengine_dli_global_variable | ||
|
||
Manages a DLI global variable resource within FlexibleEngineCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
Manages a DLI global variable resource within FlexibleEngineCloud. | |
Manages a DLI global variable resource within FlexibleEngine. |
Zippo-Wang
force-pushed
the
migrate_DLI-dli_global_variable
branch
from
October 19, 2023 02:26
68c01ec
to
d40fe45
Compare
/lgtm |
Zippo-Wang
added a commit
to Zippo-Wang/terraform-provider-flexibleengine
that referenced
this pull request
Nov 10, 2023
Zippo-Wang
added a commit
to Zippo-Wang/terraform-provider-flexibleengine
that referenced
this pull request
Nov 10, 2023
Zippo-Wang
added a commit
to Zippo-Wang/terraform-provider-flexibleengine
that referenced
this pull request
Nov 10, 2023
Zhukun-Huawei
pushed a commit
to Zhukun-Huawei/terraform-provider-flexibleengine
that referenced
this pull request
Nov 20, 2023
Zhukun-Huawei
pushed a commit
to Zhukun-Huawei/terraform-provider-flexibleengine
that referenced
this pull request
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
import
resource_flexibleengine_dli_global_variable
resource, unit test and documentWhich issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)fixes #xxx
Special notes for your reviewer:
Release note:
PR Checklist
Acceptance Steps Performed