Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DLI): import DLI global variable resource and add unit test and document. #1034

Conversation

Zippo-Wang
Copy link
Contributor

@Zippo-Wang Zippo-Wang commented Oct 11, 2023

What this PR does / why we need it:
import resource_flexibleengine_dli_global_variable resource, unit test and document

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

=== RUN   TestAccGlobalVariable_basic
=== PAUSE TestAccGlobalVariable_basic
=== CONT  TestAccGlobalVariable_basic
--- PASS: TestAccGlobalVariable_basic (231.00s)

PASS

coverage: 1.7% of statements in ../../../terraform-provider-flexibleengine/...

@Zippo-Wang Zippo-Wang force-pushed the migrate_DLI-dli_global_variable branch from 830b904 to 16879ad Compare October 11, 2023 06:25
@Zippo-Wang Zippo-Wang changed the title test(DLI): import DLI global variable resource and add unit test and document. feat(DLI): import DLI global variable resource and add unit test and document. Oct 11, 2023
Copy link
Contributor

@chengxiangdong chengxiangdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some little nits, can you fix them.

@Zippo-Wang Zippo-Wang force-pushed the migrate_DLI-dli_global_variable branch from 16879ad to 68c01ec Compare October 16, 2023 09:20
@chengxiangdong
Copy link
Contributor

/lgtm

@github-actions github-actions bot added the LGTM label Oct 18, 2023

# flexibleengine_dli_global_variable

Manages a DLI global variable resource within FlexibleEngineCloud.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Manages a DLI global variable resource within FlexibleEngineCloud.
Manages a DLI global variable resource within FlexibleEngine.

@Zippo-Wang Zippo-Wang force-pushed the migrate_DLI-dli_global_variable branch from 68c01ec to d40fe45 Compare October 19, 2023 02:26
@github-actions github-actions bot removed the LGTM label Oct 19, 2023
@chengxiangdong
Copy link
Contributor

/lgtm

@github-actions github-actions bot added the LGTM label Oct 19, 2023
@ShiChangkuo ShiChangkuo merged commit c14dba5 into FlexibleEngineCloud:master Oct 24, 2023
4 checks passed
@Zippo-Wang Zippo-Wang deleted the migrate_DLI-dli_global_variable branch November 1, 2023 07:15
Zippo-Wang added a commit to Zippo-Wang/terraform-provider-flexibleengine that referenced this pull request Nov 10, 2023
Zippo-Wang added a commit to Zippo-Wang/terraform-provider-flexibleengine that referenced this pull request Nov 10, 2023
Zippo-Wang added a commit to Zippo-Wang/terraform-provider-flexibleengine that referenced this pull request Nov 10, 2023
Zhukun-Huawei pushed a commit to Zhukun-Huawei/terraform-provider-flexibleengine that referenced this pull request Nov 20, 2023
Zhukun-Huawei pushed a commit to Zhukun-Huawei/terraform-provider-flexibleengine that referenced this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants